Skip to content

substrate: clarify ../SQLSharp also good TypeScript-post-install reference — LFG sibling of AceHack #42#643

Merged
AceHack merged 3 commits intomainfrom
lfg/sibling-pr-42-sqlsharp-ts-clarification
Apr 27, 2026
Merged

substrate: clarify ../SQLSharp also good TypeScript-post-install reference — LFG sibling of AceHack #42#643
AceHack merged 3 commits intomainfrom
lfg/sibling-pr-42-sqlsharp-ts-clarification

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented Apr 27, 2026

LFG sibling of AceHack #42. Adds the ../SQLSharp as TypeScript-post-install reference clarification to the install-strategy memory file body. Substrate-only.

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings April 27, 2026 15:22
@AceHack AceHack enabled auto-merge (squash) April 27, 2026 15:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds clarification to the install-strategy memory doc that ../SQLSharp is also a useful reference for TypeScript post-install script patterns (in addition to its other roles as a read-only sibling repo reference).

Changes:

  • Add a new section documenting ../SQLSharp as a reference source for TypeScript post-install scripts.
  • Explain how those scripts can be mined as templates when porting bash post-install logic to Bun + TypeScript.

…ference (#42)

Aaron 2026-04-27: "../SQLSharp is a good example of typescript
post intall scripts too"

While ../SQLSharp is primarily the pre-DBSP event-stream-
processing seed (LINQ/SQL flavor), it also contains TypeScript
post-install scripts that serve as good reference templates
for the post-install→TypeScript pattern this strategy codifies.
When porting bash post-install scripts to TypeScript, mine
../SQLSharp's TS post-install scripts for shape rather than
rediscovering the patterns.

Composes with the laptop-source-integration triage:
post-install-script TEMPLATES are themselves a feature that
either ships in-repo (port the templates) or design-docs the
shape (capture conventions in
docs/research/post-install-typescript-conventions.md).

Per AgencySignature v1 (Otto-138):
Author: Otto (Anthropic-side AI agent on the Zeta factory)
Origin-substrate: AceHack/Zeta main

Co-authored-by: Otto <noreply@anthropic.com>
@AceHack AceHack force-pushed the lfg/sibling-pr-42-sqlsharp-ts-clarification branch from d46d802 to 2d575cf Compare April 27, 2026 15:27
…sharp-ts-clarification

# Conflicts:
#	memory/MEMORY.md
Copilot AI review requested due to automatic review settings April 27, 2026 15:38
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread memory/MEMORY.md
…c xref (Copilot P1 x2)

Two unresolved Copilot P1 threads on this PR; both valid.

Thread 1 (memory/MEMORY.md): the laptop-only-source-integration index
entry was inadvertently removed alongside the install-strategy entry
edit. Restore it — the memory file still exists and remains
discoverable from the index. Also folds in the prior "outside
enumerated history-of-the-work surface" qualifier on the done
criterion (matches the AceHack-main version).

Thread 2 (memory/project_install_script_language_strategy_*.md): the
text referenced `docs/research/post-install-typescript-conventions.md`
ambiguously ("capture the conventions in <path> or similar") which
Copilot read as a claim that the doc exists. Reword to make explicit
that this is a proposed future location, not a current reference.

LFG sibling fix-forward — the AceHack equivalent of thread 2 will
land via a separate small substrate PR on AceHack to keep the
homebase-first invariant.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AceHack added a commit to AceHack/Zeta that referenced this pull request Apr 27, 2026
…integrity hook)

The memory-index-integrity check on AceHack #46 flagged the missing
paired MEMORY.md edit when the install-strategy memory file was
modified. Add a one-line note to the index entry recording the
2026-04-27 wording fix per Copilot LFG Lucent-Financial-Group#643 P1.

Hook satisfied; auto-merge will retry.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@AceHack AceHack merged commit 76ac6f8 into main Apr 27, 2026
22 checks passed
@AceHack AceHack deleted the lfg/sibling-pr-42-sqlsharp-ts-clarification branch April 27, 2026 16:05
AceHack added a commit to AceHack/Zeta that referenced this pull request Apr 27, 2026
…current reference (#46)

* fix(substrate): reword nonexistent-doc xref — `docs/research/post-install-typescript-conventions.md` is a proposed location, not a current reference

Copilot P1 finding on the LFG sibling PR (Lucent-Financial-Group#643)
flagged that the install-script language-strategy memory file referenced
`docs/research/post-install-typescript-conventions.md` ambiguously
("capture the conventions in <path> or similar"). The path doesn't
exist; readers (Copilot included) parse this as if the doc were a real
artifact.

Reword to make it explicit that this is a proposed future location,
not a current reference. Same fix already landed on the LFG sibling
branch; this PR keeps the AceHack homebase-first invariant.

No behavioural change. Substrate-text only.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(MEMORY.md): paired-edit for nonexistent-doc reword (memory-index-integrity hook)

The memory-index-integrity check on AceHack #46 flagged the missing
paired MEMORY.md edit when the install-strategy memory file was
modified. Add a one-line note to the index entry recording the
2026-04-27 wording fix per Copilot LFG Lucent-Financial-Group#643 P1.

Hook satisfied; auto-merge will retry.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
AceHack added a commit that referenced this pull request Apr 27, 2026
…nonexistent doc xref) (#645)

* ci: rename nightly-low-memory.yml → low-memory.yml (cadence is config, not identity) (#45)

* ci: rename nightly-low-memory.yml to low-memory.yml — cadence is config, not identity

Maintainer 2026-04-27: *"when it becomes per merge this won't be a
good filename anymore"*. With #44 the workflow now triggers on every
merge to main + nightly + workflow_dispatch — "nightly" in the
filename is misleading.

Rename rationale:
- `low-memory.yml` describes the *purpose* (low-memory drift
  detection on ubuntu-slim).
- The cadence (per-merge + nightly + manual) is a config detail
  that lives inside the file's `on:` block. Filename should not
  encode mutable cadence — it should encode timeless intent.
- Filename-history note retained inside the file's header comment
  so future maintainers can find the rename via grep.

Updated:
- `name:` field: `nightly-low-memory` → `low-memory`
- `concurrency.group:` `nightly-low-memory` → `low-memory`
- `gate.yml` cross-references at lines 12, 99, 125
- Header comment block reframed (purpose + filename history)

Branch protection: this workflow runs on push-to-main (not pull_request),
so it never appears as a PR-level required-status-check. No
branch-protection update needed.

LFG sibling: forward-sync via cherry-pick after this lands on AceHack.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs: clarify push-to-main vs merge-to-main per Copilot P2 (PR #45 thread)

Copilot P2 finding: comments said "every merge to main" but the
trigger is actually \`push: branches: [main]\` which is broader
than merges (also fires on direct pushes if branch protection
ever lifts).

Reword to "every push to main (in practice every merge — direct
pushes are blocked by branch protection)" so the technical
behavior and policy intent are both clear without misleading
future readers.

Two files touched (gate.yml header + low-memory.yml header).
The intra-policy phrasing inside Aaron's verbatim quote and the
"Why post-merge + nightly..." rationale stay as merge-language —
those describe policy/intent, not technical behavior.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

* fix(substrate): reword nonexistent-doc xref → proposed location, not current reference (#46)

* fix(substrate): reword nonexistent-doc xref — `docs/research/post-install-typescript-conventions.md` is a proposed location, not a current reference

Copilot P1 finding on the LFG sibling PR (#643)
flagged that the install-script language-strategy memory file referenced
`docs/research/post-install-typescript-conventions.md` ambiguously
("capture the conventions in <path> or similar"). The path doesn't
exist; readers (Copilot included) parse this as if the doc were a real
artifact.

Reword to make it explicit that this is a proposed future location,
not a current reference. Same fix already landed on the LFG sibling
branch; this PR keeps the AceHack homebase-first invariant.

No behavioural change. Substrate-text only.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(MEMORY.md): paired-edit for nonexistent-doc reword (memory-index-integrity hook)

The memory-index-integrity check on AceHack #46 flagged the missing
paired MEMORY.md edit when the install-strategy memory file was
modified. Add a one-line note to the index entry recording the
2026-04-27 wording fix per Copilot LFG #643 P1.

Hook satisfied; auto-merge will retry.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

* preserve(threads): per-commit concurrency from LFG #644 (Codex P2 + Copilot P1)

The cherry-pick from AceHack #45 used --strategy-option=theirs which
took the AceHack version of low-memory.yml — that version had the
older constant-group concurrency (\`group: low-memory\`,
cancel-in-progress: false), which silently replaces older pending
runs on burst pushes.

Restore the per-commit concurrency improvement that landed on LFG
#644 (\`group: low-memory-\${{ github.sha }}\`) so this forward-sync
doesn't regress the LFG state. Each push to main gets its own slot,
runs in parallel, no replacement.

Follow-up: open a small AceHack PR with the same concurrency fix to
keep the homebase-first invariant — next AceHack→LFG sync round
should be 0-diff on this file.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants